Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table and Figure S1 legends #54

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Table and Figure S1 legends #54

merged 10 commits into from
Mar 4, 2024

Conversation

sjspielman
Copy link
Member

Closes #32
Towards #14

This PR adds the legend for Table S1 and Figure S1. I included the link to display Fig S1 in the document, but not Table S1 b/c it's a table. But, we could add a markdown version of the table directly in here if we want..?

For Figure S1, I am looking for some recommendations to tighten up the wording. I feel it's a little repetitive now. I tried to ameliorate some of that by grouping some text that was similar to either all panels, or all panels B-D, but I think it can maybe be tightened up further. On the other hand, we could go the exact opposite route and not tighten up at all, but "loosen" the text to be more descriptive about each panel on its own terms!

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 5a692fc.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 1b31527.

Manuscript build

@sjspielman
Copy link
Member Author

Hm maybe we need supplemental in another document, because it is insisting on labeling this as Figure 5 as the 5th figure in the document!

Screenshot 2024-02-28 at 4 22 33 PM

@sjspielman sjspielman requested a review from allyhawkins March 4, 2024 14:25
Copy link

github-actions bot commented Mar 4, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 1673574.

Manuscript build

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should probably try and figure out the issue with figure 5 being prefixed to the legend.
On that same note, I noticed that all the other ones have Figure X: Figure X. Description. I think we should make sure that the Figure X is only written one time in the legend title.

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
All remaining columns give the number of libraries (as designated with `(L)`) with the given suspension or additional modality.


![**Figure S1. Results from benchmarking `alevin-fry` and `CellRanger` performance.**](https://raw.githubusercontent.com/AlexsLemonade/scpca-paper-figures/main/figures/compiled_figures/pngs/figure_s1.png?sanitize=true){#fig:figs1 width="7in"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is still rendering as Figure 5. I feel like we might want to figure that out before merging this in?

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
@sjspielman
Copy link
Member Author

Aha, found answers to supplemental figure numbering - https://github.com/manubot/try-manubot/blob/main/USAGE.md#figures

Copy link

github-actions bot commented Mar 4, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 3fd7290.

Manuscript build

@sjspielman
Copy link
Member Author

Legend titles now working as expected!

@sjspielman sjspielman requested a review from allyhawkins March 4, 2024 17:06
Copy link

github-actions bot commented Mar 4, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e35d2a2.

Manuscript build

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjspielman sjspielman merged commit c72242e into main Mar 4, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/s1-legends branch March 7, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table legend: Table S1 legend
2 participants